Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs #36

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Add docs #36

merged 4 commits into from
Oct 10, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Oct 10, 2024

What I am changing

  • Add docs

How I did it

  • mkdocs-material and mike
  • I put the Python docs in the stubs file
  • Since it's a small repo, I KISS-ed it to a single mkdocs build — I figure we can keep all the versions (CLI, Python, and Rust) the same, and if we want to break that we can break out the docs later?

How you can test it

Related Issues

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/python.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
@kylebarron
Copy link
Member

  • Since it's a small repo, I KISS-ed it to a single mkdocs build — I figure we can keep all the versions (CLI, Python, and Rust) the same, and if we want to break that we can break out the docs later?

I don't feel the need to have rust documentation in the mkdocs site. IMO any docs targeting rust users should live at docs.rs/cql2.

Yeah developmentseed.org is hosted on github pages I believe, so any repo's github pages automatically get served from developmentseed.org.

- name: Deploy
run: |
VERSION=$(git describe --tags --match="v*" --abbrev=0)
uv run mike deploy $VERSION latest --update-aliases --push
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a personal nit to always have an end of line character on the last line. I set this in my editor settings and also have pre-commit setups that enforce this on my own projects: https://github.com/developmentseed/lonboard/blob/4af9e2de490e99092fffafae817078e30da94bc2/.pre-commit-config.yaml#L16

run: uv sync
- name: Deploy
run: |
VERSION=$(git describe --tags --match="v*" --abbrev=0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you expect to ever publish beta versions? I find myself pushing alpha/beta versions decently often, but don't want to publish those to the public docs website: https://github.com/developmentseed/lonboard/blob/4af9e2de490e99092fffafae817078e30da94bc2/.github/workflows/deploy-mkdocs.yml#L59-L63

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't anticipate that very often for this repo — my hope is that we bake it and it just gets used.

python/cql2.pyi Outdated Show resolved Hide resolved
@gadomski gadomski merged commit dcc03f7 into main Oct 10, 2024
18 checks passed
@gadomski gadomski deleted the issues/31-docs branch October 10, 2024 16:26
@gadomski gadomski mentioned this pull request Oct 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to --workspace in CI Python documentation
3 participants